Add example Relay provider and export relay Feedback example component#141
Conversation
alloy
force-pushed
the
alloy/make-examples-package-a-useable-canary-for-host-app-bootstrapping
branch
from
19f69ae to
98f8ad2
Compare
alloy
changed the title
|
@sjwilczynski Unless you see any hard blockers, can you please merge this as soon as you have reviewed it? I would like to have a package published by tomorrow morning pacific time. |
| * @returns Array containing mutation committer function and a flag | ||
| * indicating whether mutation is "in flight". | ||
| */ | ||
| export function useRelayMutationWithApolloAPI< |
There was a problem hiding this comment.
With this change we start having two different implementation of Nova relay based environment, the other one exists in packages\nova-react-test-utils\src\relay\nova-relay-graphql.ts. We shouldn't, it's going to be confusing as hell why certain things work in Storybook differently than in imported env from examples package.
In 1JS (and in Outlook) nova env based on relay is using suspending useLazyLoadQuery and we accepted the consequence that Nova interface is not exactly followed (as we never return error) and TBH I am now surprised Teams went in different direction. Seems we need to discuss and align on this in a forum.
For now I will approve and merge the PR, to allow you to share this with folks, but without this need I would block it until we aligned, so please follow up on it
There was a problem hiding this comment.
Agreed, and yesterday I was reminded of this PR that I recall was attempting to align some of this #117
@sergey-stoyan Can you make sure to join a next nova sync together with @sjwilczynski so we can discuss this topic?
There was a problem hiding this comment.
Sure, let's discuss during the next sync
|
|
||
| /** | ||
| * Hook that wraps useQuery hook from "relay-hooks" library and returns a Nova API compatible response. | ||
| * We can't use original Relay useLazyLoadQuery, since its implementation is heavily relies on Suspense. |
There was a problem hiding this comment.
| * We can't use original Relay useLazyLoadQuery, since its implementation is heavily relies on Suspense. | |
| * We can't use original Relay useLazyLoadQuery, since its implementation heavily relies on Suspense. |
sjwilczynski
deleted the
alloy/make-examples-package-a-useable-canary-for-host-app-bootstrapping
branch
3 participants
Per discussion with the PowerAutomate folks, they are wanting to integrate some Nova components. We'll be making the Feedback example component available as a canary Nova component to test the host's Nova facade setup.
This first PR only implements a Relay GraphQL provider. Adding an eventing and commanding provider should be straightforward.